Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: end users should not have permissions to edit */status #1224

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@mengqiy
Copy link
Contributor

mengqiy commented Nov 25, 2019

As @erictune pointed out in #1165 (comment), editor role is intended for end users which should not have permissions to edit */status.

fixes #886

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Liujingfang1 and pwittrock Nov 25, 2019
@mengqiy mengqiy requested review from camilamacedo86 and droot and removed request for pwittrock and Liujingfang1 Nov 25, 2019
Copy link
Contributor

camilamacedo86 left a comment

/lgtm
/approved

Thank you for png me @mengqiy and clarifies what was missing/wrong with.

@Adirio

This comment has been minimized.

Copy link
Contributor

Adirio commented Nov 25, 2019

GitHub was a bit laggy and I think that caused the Travis fail, you should probably re-run Travis

@Adirio
Adirio approved these changes Nov 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit fc60d25 into kubernetes-sigs:master Nov 25, 2019
7 of 8 checks passed
7 of 8 checks passed
tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation mengqiy authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details
pull-kubebuilder-e2e-k8s-1-14-1 Job succeeded.
Details
pull-kubebuilder-e2e-k8s-1-15-3 Job succeeded.
Details
pull-kubebuilder-e2e-k8s-1-16-2 Job succeeded.
Details
pull-kubebuilder-test Job succeeded.
Details
@mengqiy mengqiy deleted the mengqiy:editorrole branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.