Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo #1232

Merged
merged 1 commit into from Dec 3, 2019
Merged

Fix minor typo #1232

merged 1 commit into from Dec 3, 2019

Conversation

@gosharplite
Copy link
Contributor

gosharplite commented Dec 2, 2019

No description provided.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

Hi @gosharplite. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gosharplite

This comment has been minimized.

Copy link
Contributor Author

gosharplite commented Dec 2, 2019

/assign @droot

@mengqiy

This comment has been minimized.

Copy link
Contributor

mengqiy commented Dec 3, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gosharplite, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 696e827 into kubernetes-sigs:master Dec 3, 2019
3 of 8 checks passed
3 of 8 checks passed
pull-kubebuilder-e2e-k8s-1-14-1 Job triggered.
Details
pull-kubebuilder-e2e-k8s-1-15-3 Job triggered.
Details
pull-kubebuilder-e2e-k8s-1-16-2 Job triggered.
Details
pull-kubebuilder-test Job triggered.
Details
tide Not mergeable.
Details
cla/linuxfoundation gosharplite authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.