New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brew install to quickstart for MACs #2245
Conversation
Welcome @omer-shtivi! |
Hi @omer-shtivi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omer-shtivi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @omer-shtivi,
Thank you for your contribution 🥇
Homebrew formula is not maintained by Kubebuidler. So, I think it is nice we add this info but imo that would fit better in a note after Using master branch
and similar to that:
In this way, following my suggestion:
Using Homebrew (MacOS)
You can install Kubebuilder by using Homebrew. However, note that its formula is not maintained and officially supported by Kubebuilder.
brew install kubebuilder
Also, note that for we move forward with your is required to:
- Following the instructions in: Add brew install to quickstart for MACs #2245 (comment)
- Ensure that your commits are rebased
- Update the title with the mojo
:book:
. For further information see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#pr-process
Hi @omer-shtivi, Could you please address the suggestion #2245 (review) for we are able to get it merged? |
HI @omer-shtivi, This PR is open for a while. You need to register to CA and address the comment: #2245 (review) for we are able to move forward. I hope that is fine we close this one for now. Also, feel free to reach me out via the slack channel for we are able to move forward. |
Add homebrew installation to quickstart for MAC users