Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump Kubernetes version (1.24.1 -> 1.25.0) #2907

Closed
wants to merge 1 commit into from

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 6, 2022

Bump Kubernetes version (1.24.1 -> 1.25.0) as part of kubernetes-sigs/cluster-api#6661

cc @sbueringer

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oscr
Once this PR has been reviewed and has the lgtm label, please assign pwittrock for approval by writing /assign @pwittrock in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
@sbueringer
Copy link
Member

Looks good. I think you have to add a bit more text to the PR description to make the PR verifier happy.

/lgtm

/assign @camilamacedo86
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@@ -44,7 +44,7 @@ builds:
- darwin_amd64
- darwin_arm64
env:
- KUBERNETES_VERSION=1.24.1
- KUBERNETES_VERSION=1.25.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Thank you for the contribution 馃

We need to update the whole project accordingly and not only the goreleaser file.
See: #2908

Would you like to start to help out by creating the envtools binaries for 1.25?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thank sounds great @camilamacedo86.

Copy link
Member

@sbueringer sbueringer Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 Thx, I overlooked the base branch of this PR.

Just out of curiosity. Does bumping the version on the tools-releases branch depend on kubebuilder itself on main being bumped before?

EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbueringer,

EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first

We use the envtest in the scaffolds as well see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile#L5

But updating the goreleases would need to be done when we update the whole project.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@sbueringer
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@camilamacedo86
Copy link
Member

Hi @oscr,

To do the bump that means updating all project, scaffolds and dependencies.
So, I am closing this one but feel free to re-open if you would like to use this PR to do that

@oscr oscr deleted the bump-kubernetes-version branch September 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants