New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable prometheus metrics integration #468

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
4 participants
@droot
Contributor

droot commented Nov 1, 2018

Quick highlights:

  • Scaffolds a patch which enables prometheus scraping on the manager pods. Using the most common annotations used by Stackdriver, weaveworks
  • Enables the patch in kustomization.yaml file.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from pmorie and pwittrock Nov 1, 2018

@JoelSpeed

This looks like it should work for the default case

@mengqiy

This comment has been minimized.

Contributor

mengqiy commented Nov 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 5, 2018

@k8s-ci-robot k8s-ci-robot merged commit 2d76020 into kubernetes-sigs:master Nov 5, 2018

3 checks passed

cla/linuxfoundation droot authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment