New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to test installation script #504

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@Simon-Li
Contributor

Simon-Li commented Dec 1, 2018

For #497

@droot

Thanks for submitting this PR. one small nit, otherwise looks good.

fi
echo "passed\n"
echo "2. Check whether $KUBEBUILDER_DIR folder is existed.\n"

This comment has been minimized.

@droot

droot Dec 3, 2018

Contributor

s/is existed/exists

This comment has been minimized.

@Simon-Li

Simon-Li Dec 4, 2018

Contributor

done

echo "4. Check whether kubebuilder version is same as installed.\n"
KUBEBUILDER_VERSION_FROM_BIN=$($KUBEBUILDER_DIR/bin/kubebuilder version | \
sed 's/^.*KubeBuilderVersion:"\(.*\)", KubernetesVendor.*$/\1/')
if [ ! "${KUBEBUILDER_VERSION_FROM_BIN}" = "${KUBEBUILDER_VERSION}" ]; then

This comment has been minimized.

@droot

droot Dec 3, 2018

Contributor

Nice :)

@droot

This comment has been minimized.

Contributor

droot commented Dec 3, 2018

Also, please squash all your commits into one commit.

@Simon-Li Simon-Li force-pushed the Simon-Li:dev_install_test branch from d9a65b8 to 50f35a5 Dec 4, 2018

@Simon-Li Simon-Li force-pushed the Simon-Li:dev_install_test branch from 50f35a5 to 1e9ac15 Dec 4, 2018

@Simon-Li

This comment has been minimized.

Contributor

Simon-Li commented Dec 4, 2018

@droot updates pushed.

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Simon-Li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b46e405 into kubernetes-sigs:master Dec 4, 2018

3 checks passed

cla/linuxfoundation Simon-Li authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment