Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:running: switch to using Go modules in build tooling #704

Merged

Conversation

Projects
None yet
3 participants
@droot
Copy link
Contributor

commented May 16, 2019

Highlights:

  • use Goreleaser with Go 1.12.5
  • Enable Go modules
🏃 switch to using Go modules in build tooling
Highlights:
 - use Goreleaser with Go 1.12.5
 - Enable Go modules

@droot droot requested a review from mengqiy May 16, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mengqiy

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit fbf8a02 into kubernetes-sigs:master May 16, 2019

3 of 4 checks passed

tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation droot authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details

droot added a commit to droot/kubebuilder that referenced this pull request May 16, 2019

Merge pull request kubernetes-sigs#704 from droot/running/switch-to-g…
…o-modules

🏃 switch to using Go modules in build tooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.