Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:book: Fix cronjob tutorial to delete and get next schedule correctly #929

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@khchan123
Copy link
Contributor

commented Aug 9, 2019

  • Support default parameter field
  • Fix wrong deletion on SuccessfulJobsHistoryLimit & FailedJobsHistoryLimit
  • Fix wrong next schedule as returned lastMissed is a pointer
  • Delete dependent Job in background when deleting CronJob
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Welcome @khchan123!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@khchan123

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

I signed it

@khchan123

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

/assign @Liujingfang1

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Can we just move the defaulting to the defaulting webhook, please?

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

otherwise seems reasonable

📖 Fix cronjob tutorial to delete and get next schedule correctly
- Fix wrong deletion on SuccessfulJobsHistoryLimit & FailedJobsHistoryLimit
- Fix wrong next schedule as returned lastMissed is a pointer
- Delete dependent Job in background when deleting CronJob

@khchan123 khchan123 force-pushed the khchan123:fix-cronjob branch from cef8639 to 5c79a48 Aug 10, 2019

@khchan123

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

I overlooked and figured out the defaulting code already on webhook. Removed that part in the new version.

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, khchan123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 634f2b1 into kubernetes-sigs:master Aug 14, 2019

3 of 4 checks passed

tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation khchan123 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.