Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: Change makefile in v2 scaffolding to use ./... #940

Conversation

@DirectXMan12
Copy link
Contributor

commented Aug 14, 2019

Previously, we had some spots where we were using ./api/... and
./controllers/... specifically. Using ./... instead allows us to
handle cases where we're lacking api/, and should otherwise be fine
since we don't have a vendor directory.

Ref #925

Change makefile in v2 scaffolding to use ./...
Previously, we had some spots where we were using `./api/...` and
`./controllers/...` specifically.  Using `./...` instead allows us to
handle cases where we're lacking `api/`, and should otherwise be fine
since we don't have a vendor directory.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DirectXMan12 DirectXMan12 changed the title Change makefile in v2 scaffolding to use ./... :bug: Change makefile in v2 scaffolding to use ./... Aug 14, 2019

@k8s-ci-robot k8s-ci-robot requested review from Liujingfang1 and pwittrock Aug 14, 2019

@DirectXMan12 DirectXMan12 added this to Code Awaiting Review in 2.0.0 cross-project tracking Aug 14, 2019

@droot droot added the lgtm label Aug 14, 2019

@k8s-ci-robot k8s-ci-robot merged commit b31507b into kubernetes-sigs:master Aug 14, 2019

3 of 4 checks passed

tide Not mergeable. Job continuous-integration/travis-ci/pr has not succeeded.
Details
cla/linuxfoundation DirectXMan12 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details

2.0.0 cross-project tracking automation moved this from Code Awaiting Review to Done Aug 14, 2019

@DirectXMan12 DirectXMan12 deleted the DirectXMan12:bug/handle-missing-api-in-makefile branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.