Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting started to contribute with. Add makefile commands and improve CONTRIBUTING.MD #981

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@camilamacedo86
Copy link
Contributor

commented Sep 6, 2019

Motivation

What

Small changes in order to make clear the fixed path that the devs should use as add script to test the build and e2e in the makefile.

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@camilamacedo86 camilamacedo86 changed the title getting starte to contribute with. Add makefile commands and improve CONTRIBUTING.MD getting started to contribute with. Add makefile commands and improve CONTRIBUTING.MD Sep 6, 2019

CONTRIBUTING.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved

@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:contributing branch 2 times, most recently from 06711a8 to 5f490e6 Sep 9, 2019

@camilamacedo86 camilamacedo86 requested a review from DirectXMan12 Sep 9, 2019

@DirectXMan12
Copy link
Contributor

left a comment

tiny typo, otherwise looks good now

CONTRIBUTING.md Outdated Show resolved Hide resolved

@camilamacedo86 camilamacedo86 force-pushed the camilamacedo86:contributing branch from 52e8228 to de899bd Sep 9, 2019

@camilamacedo86 camilamacedo86 requested a review from DirectXMan12 Sep 9, 2019

@camilamacedo86

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

HI @DirectXMan12,

All requests are done. Please, feel free to check. really tks for your time.

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

/lgtm
/approve

@DirectXMan12

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1f4fc57 into kubernetes-sigs:master Sep 10, 2019

3 of 4 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation camilamacedo86 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/kubebuilder/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.