This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: use cert-mananager.io/v1 group/version #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@jimmidyson here is what you were suggesting from PR: #1288. This would be a breaking change. The alternative approach would be to change the defaults to those we manually set here. Let me know what you prefer. |
|
/assign @irfanurrehman |
hectorj2f
approved these changes
Oct 1, 2020
makkes
approved these changes
Oct 2, 2020
|
/lgtm |
|
@alejandroEsc thanks for doing this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandroEsc, irfanurrehman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes cert-manager resources to those whose group/version are "cert-manager.io/v1"
This was tested on a kind cluster with the latest version of cert-manager.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: