Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master label should be `node-role.kubernetes.io/master: ""` #2108

Closed
tamalsaha opened this issue Dec 22, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@tamalsaha
Copy link

commented Dec 22, 2017

It seems that kubespray applies the label node-role.kubernetes.io/master: "true" but kubeadm design doc says it should be node-role.kubernetes.io/master: ""

https://github.com/kubernetes/kubeadm/blob/master/docs/design/design_v1.9.md#mark-master

cc: @luxas

@tamalsaha

This comment has been minimized.

Copy link
Author

commented Dec 22, 2017

/kind bug

@towolf

This comment has been minimized.

Copy link

commented Dec 25, 2017

Counterpoint, Prometheus cannot handle empty labels, and hence it is tricky to distinguish master nodes from regular nodes:

coreos/tectonic-installer#1439

@tamalsaha

This comment has been minimized.

Copy link
Author

commented Dec 26, 2017

This sounds like a Prometheus bug.

tamalsaha added a commit to appscode/guard that referenced this issue Apr 13, 2018

tamalsaha added a commit to appscode/guard that referenced this issue Apr 13, 2018

tamalsaha added a commit to appscode/guard that referenced this issue Apr 13, 2018

zonca added a commit to zonca/jetstream_kubespray that referenced this issue Feb 23, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 10, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@fejta-bot

This comment has been minimized.

Copy link

commented May 10, 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.