generated /etc/hosts names are backwards

[anarcat]

The /etc/hosts files generated by kubespray are useful, but actually use an incorrect (but common) syntax, for example:

# Ansible inventory hosts BEGIN
10.0.1.20 kubeadmin kubeadmin.example.org
10.0.1.21 kube01 kube01.example.org
10.0.1.22 kube02 kube02.example.org
# Ansible inventory hosts END

Notice how the short domain name (e.g. kubeadmin) is before the fully-qualified domain name (FQDN, kubeadmin.example.org).

This is, arguably, a very minor difference, but it has an impact over unrelated components. For example, hostname -f does not return the right domain name:

$ hostname
kubeadmin
$ hostname -f
kubeadmin

A properly configured host would return a FQDN for hostname -f, like this:

$ hostname
kubeadmin
$ hostname -f
kubeadmin.example.org

The /etc/hosts manual page is pretty clear on the topic:

For each host a single line should be present with the following information:

IP_address canonical_hostname [aliases...]

[...] Optional aliases provide for name changes, alternate spellings, shorter hostnames, or generic hostnames (for example, localhost).

The EXAMPLES section is similarly unambiguous: the FQDN comes first.

Reversing those domain names in the /etc/hosts file will fix that problem, for which I will submit a PR shortly.

Environment:

• Cloud provider or hardware configuration: baremetal
• OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): Linux 4.9.0-7-amd64 x86_64 Debian GNU/Linux 9 (stretch)
• Version of Ansible (ansible --version): N/A

Kubespray version (commit) (git rev-parse --short HEAD): v2.5.0 (but also applies to later versions)

Network plugin used: calico

Copy of your inventory file:

[all]
kubeadmin        ansible_host=192.168.0.1 ip=10.0.1.20
kube01           ansible_host=192.168.0.2 ip=10.0.1.21
kube02           ansible_host=192.168.0.2 ip=10.0.1.22

[kube-master]
kubeadmin

[kube-node]
kubeadmin
kube01
kube02

[etcd]
kubeadmin

[k8s-cluster:children]
kube-node
kube-master

[calico-rr]

[vault]
kubeadmin
kube01
kube02

Command used to invoke ansible:

ansible-playbook -u root -b -i inventory/mykube/hosts.ini cluster.yml

Output of ansible run:

N/A

[stevencox]

@anarcat - I'm still seeing the behavior the commit above fixes. The ouptut of git show in my cloned repo starts with:

commit a3a7fe7c8ebf64c76713bed275dda59acba47bc2
Author: 刘旭 <liuxu623@gmail.com>
Date:   Tue Jun 11 19:56:18 2019 +0800

So I think I'm using recent work. Is there something additional I need to configure so that your fix takes effect?

[anarcat]

no idea. i think you'd need to provide more details or open a separate bug.