Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear ipvs virtual server table when reset k8s #3530

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@sufuf3
Copy link
Contributor

commented Oct 16, 2018

I used kube-proxy ipvs mode, after I reset the cluster, I found the virtual server table of ipvsadm still there.
So I want to improve the reset part for clear ipvs virtual server table.
Thank you.
cc #3465, #3416

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sufuf3

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

I signed the CLA.

@sufuf3 sufuf3 force-pushed the sufuf3:add-clear-ipvs-vstable branch from deae713 to 6865398 Oct 16, 2018

@Atoms

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@sufuf3 please check if CLA signed with same email commit has

@@ -107,6 +107,10 @@
tags:
- iptables

- name: Clear IPVS virtual server table
shell: "ipvsadm -C"
when: clear_ipvs_vstable|bool

This comment has been minimized.

Copy link
@Atoms

Atoms Oct 16, 2018

Member
  1. when statement as list
when:
    - statement
  1. it should detect and clear ipvs table when kube_proxy_mode is set to ipvs, and not introduce new variable

@sufuf3 sufuf3 force-pushed the sufuf3:add-clear-ipvs-vstable branch from 6865398 to 94b8d65 Oct 16, 2018

@sufuf3

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

@Atoms Thank you for the review.
I updated it. 😃

@Atoms

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atoms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woopstar

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

ci check this

@k8s-ci-robot k8s-ci-robot merged commit 5a5cf15 into kubernetes-sigs:master Oct 16, 2018

9 of 11 checks passed

tide Not mergeable. Job kubespray-ci/pipeline has not succeeded.
Details
Kubespray CI - syntax-check Build Succeeded
Details
Kubespray CI - ci-authorized Build Succeeded
Details
Kubespray CI - gce_centos-weave-kubeadm-sep Build Succeeded
Details
Kubespray CI - gce_centos7-flannel-addons Build Succeeded
Details
Kubespray CI - gce_coreos-calico-aio Build Succeeded
Details
Kubespray CI - gce_ubuntu18-flannel-aio Build Succeeded
Details
Kubespray CI - yamllint Build Succeeded
Details
Kubespray CI Pipeline Pipeline Succeeded
Details
cla/linuxfoundation sufuf3 authorized
Details
kubespray-ci/pipeline Pipeline Succeeded
Details

@sufuf3 sufuf3 deleted the sufuf3:add-clear-ipvs-vstable branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.