New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contrib/network-storage/heketi use of assert module (message -> msg) #3677

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@japsu

japsu commented Nov 9, 2018

The heketi/roles/provision role uses message: where msg: should be used, causing a sufficiently new Ansible to error out (tested: 2.7.1).

@k8s-ci-robot k8s-ci-robot requested review from chapsuk and mirwan Nov 9, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: holser

If they are not already assigned, you can assign the PR to them by writing /assign @holser in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS label Nov 9, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 9, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Atoms

can you please rewrite this also with newlines? like:

assert:
  that:
    - condition
  msg: "..."

that is more readable way

@Atoms

This comment has been minimized.

Contributor

Atoms commented Nov 9, 2018

Please sign CLA

@japsu

This comment has been minimized.

japsu commented Nov 9, 2018

@Atoms Thank you for the feedback, I'll reformat the file in question.

Regarding the CLA, I'm waiting for confirmation e-mail from the Linux Foundation site, haven't received it yet.

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Nov 9, 2018

@Atoms

This comment has been minimized.

Contributor

Atoms commented Nov 9, 2018

you need to sign CLA with same email commit has.

@japsu

This comment has been minimized.

japsu commented Nov 10, 2018

In order to be able to sign the CLA, waiting for the Linux Foundation helpdesk to assist me with an authentication problem. Until they co-operate, I can't sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment