Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more links to the docs #4204

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@Miouge1
Copy link
Member

Miouge1 commented Feb 8, 2019

In the initial docsify PR #4193 I forgot to link to a couple of pages, so here it is: all files in docs/*.md are now in the sidebar.

I'm not sure if it's a good thing (a big sidebar can be overwhelming) but, it's open for discussion.

@k8s-ci-robot k8s-ci-robot requested review from chadswen and mattymo Feb 8, 2019

@Miouge1

This comment has been minimized.

Copy link
Member Author

Miouge1 commented Feb 8, 2019

ci check this

@k8s-ci-robot k8s-ci-robot added the size/S label Feb 8, 2019

@riverzhang

This comment has been minimized.

Copy link
Member

riverzhang commented Feb 26, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, riverzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c36a022 into kubernetes-sigs:master Feb 26, 2019

3 checks passed

cla/linuxfoundation Miouge1 authorized
Details
kubespray-ci/pipeline Pipeline Succeeded
Details
tide In merge pool.
Details

mattymo added a commit to mattymo/kargo that referenced this pull request Mar 3, 2019

LuckySB added a commit to centosadmin/kubespray that referenced this pull request Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.