Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip coredns phase when initializing other uninitialized masters #4867

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@liuxu623
Copy link
Contributor

liuxu623 commented Jun 11, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@woopstar

This comment has been minimized.

Copy link
Member

woopstar commented Jun 11, 2019

ci check this

@woopstar woopstar changed the title fix start CoreDNS when init secondary master Skip coredns phase when initializing other uninitialized masters Jun 11, 2019
@woopstar

This comment has been minimized.

Copy link
Member

woopstar commented Jun 11, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liuxu623, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a3a7fe7 into kubernetes-sigs:master Jun 11, 2019
20 of 21 checks passed
20 of 21 checks passed
tide Not mergeable.
Details
Kubespray CI - ansible-lint Build Succeeded
Details
Kubespray CI - ci-authorized Build Succeeded
Details
Kubespray CI - packet_centos7-calico-ha Build Succeeded
Details
Kubespray CI - packet_centos7-flannel-addons Build Succeeded
Details
Kubespray CI - packet_debian9-calico-upgrade Build Succeeded
Details
Kubespray CI - packet_ubuntu-canal-kubeadm Build Succeeded
Details
Kubespray CI - packet_ubuntu-flannel-ha Build Succeeded
Details
Kubespray CI - packet_ubuntu18-calico-aio Build Succeeded
Details
Kubespray CI - shellcheck Build Succeeded
Details
Kubespray CI - syntax-check Build Succeeded
Details
Kubespray CI - tf-ovh_coreos-calico Build Succeeded
Details
Kubespray CI - tf-ovh_ubuntu18-calico Build Succeeded
Details
Kubespray CI - tf-validate-aws Build Succeeded
Details
Kubespray CI - tf-validate-openstack Build Succeeded
Details
Kubespray CI - tf-validate-packet Build Succeeded
Details
Kubespray CI - vagrant-validate Build Succeeded
Details
Kubespray CI - yamllint Build Succeeded
Details
Kubespray CI Pipeline Pipeline Succeeded
Details
cla/linuxfoundation liuxu623 authorized
Details
kubespray-ci/pipeline Pipeline Succeeded
Details
holmsten added a commit to holmsten/kubespray that referenced this pull request Jun 13, 2019
k8s-ci-robot added a commit that referenced this pull request Jun 13, 2019
* fix start CoreDNS when init secondary master (#4867)

* Update dns-autoscaler.yml.j2 (#4857)

Merge two tolerations.  because the latest tolerations will cover the first tolerations.

* Remove GCE tests and CNCF funding ended (#4859)
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Aug 4, 2019
geneliu added a commit to geneliu/kubespray that referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.