Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elastx CI (TF OpenStack) #6127

Merged
merged 1 commit into from Jun 3, 2020
Merged

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented May 11, 2020

What this PR does / why we need it:
Since the OVH voucher expired 10th of May, ELASTX (one of the leading Swedish Public Cloud provider) donated CI resources for Kubespray on OpenStack.

This PR adds a simple ubuntu18-calico CI job (it used to be on OVH CI), CoreOS image is currently not available on ELASTX, but that's not a problem since CoreOS is going EOL end of May anyway.

Big thanks to ELASTX @holmsten and @bl0m1 to make this possible! ❤️

Notes:
Changing the order of filters from kube_network_plugin_multus|bool|default(false) to kube_network_plugin_multus|default(false)|bool, to address the situation where kube_network_plugin_multus is undef as well as if kube_network_plugin_multus is a non-boolean

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2020
@Miouge1 Miouge1 force-pushed the elastx-ci branch 10 times, most recently from 2ab622d to 9fedf2e Compare May 13, 2020 15:30
@Miouge1 Miouge1 changed the title [WIP] Add Elastx CI Add Elastx CI (TF OpenStack) May 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2020
@Miouge1
Copy link
Contributor Author

Miouge1 commented May 13, 2020

It would be great to get some feedback on this from @bl0m1 or @holmsten

A couple of potential points:

  • I used v1-standard-2 since that's the smallest image with 2 cores (8GB of RAM). Kubespray with 1 core is possible, but requires to reduce the CPU request to get all pods scheduled.
  • AZ used sto1, no clue if there is a preference there?
  • Neutron Router is created by TF, it's also possible to create the Neutron Router manually and specify router_id if you prefer?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@huxcrux
Copy link
Contributor

huxcrux commented May 15, 2020

It would be great to get some feedback on this from @bl0m1 or @holmsten

A couple of potential points:

  • I used v1-standard-2 since that's the smallest image with 2 cores (8GB of RAM). Kubespray with 1 core is possible, but requires to reduce the CPU request to get all pods scheduled.
  • AZ used sto1, no clue if there is a preference there?
  • Neutron Router is created by TF, it's also possible to create the Neutron Router manually and specify router_id if you prefer?

/hold

v1-standard-2 is totally fine with us. AZ doesn't really matter all of them are identical :)

Regarding router(s) It would probably be better to manually create one and reuse for all tests.
This since we limit each tenant to one router meaning CI test could fail in case multiple ones are running at the same time.

@Miouge1 Miouge1 force-pushed the elastx-ci branch 2 times, most recently from 7ed534b to e1a9ae6 Compare May 18, 2020 12:58
TF_VAR_flavor_k8s_master: 3f73fc93-ec61-4808-88df-2580d94c1a9b # v1-standard-2
TF_VAR_flavor_k8s_node: 3f73fc93-ec61-4808-88df-2580d94c1a9b # v1-standard-2
TF_VAR_image: ubuntu-18.04-server-latest
TF_VAR_k8s_allowed_remote_ips: '["0.0.0.0/0"]'

# tf-ovh_ubuntu18-calico:
# extends: .terraform_apply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep tf-ovh_xxxx ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get OVH CI back since ELASTX and OVH are very different OpenStack environments, we can clean it up later if it doesn't work out.

@Miouge1
Copy link
Contributor Author

Miouge1 commented May 29, 2020

I ran into problems with dependencies between TF modules (subnet not finished to create when creating the VM etc...), since there is no support for depends_on on modules, I set -parallelism=1 as a quickfix.

@Miouge1 Miouge1 force-pushed the elastx-ci branch 3 times, most recently from 098be11 to ad53286 Compare May 29, 2020 19:32
@Miouge1
Copy link
Contributor Author

Miouge1 commented Jun 3, 2020

@bl0m1 and @holmsten it took a while to get things sorted out (namely the errors around kube_network_plugin_multus), but I think we're good now.

Really interesting to see the nuances with each OpenStack Public Cloud

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@floryut
Copy link
Member

floryut commented Jun 3, 2020

Ok all good then, good job
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit fd59556 into kubernetes-sigs:master Jun 3, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants