Configure wrapcheck linter to recognize wrapping done by kyaml's erro…

…rs package
kubernetes-sigs · May 9, 2022 · 7a773a3 · 7a773a3
1 parent 2e230b4
commit 7a773a3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -110,6 +110,19 @@ linters-settings:
   gomnd:
      ignored-functions:
      - ioutil.WriteFile
+  wrapcheck:
+    ignoreSigs:
+      # defaults
+      - .Errorf(
+      - errors.New(
+      - errors.Unwrap(
+      - .Wrap(
+      - .Wrapf(
+      - .WithMessage(
+      - .WithMessagef(
+      - .WithStack(
+      # from kyaml's errors package
+      - .WrapPrefixf(
 
 issues:
   new-from-rev: c94b5d8f2 # enables us to enforce a larger set of linters for new code than pass on existing code

diff --git a/kyaml/fn/framework/processors.go b/kyaml/fn/framework/processors.go
@@ -150,7 +150,7 @@ func LoadFunctionConfig(src *yaml.RNode, api interface{}) error {
 		if err != nil {
 			return errors.WrapPrefixf(err, "loading provided schema")
 		}
-		schemaValidationError = validate.AgainstSchema(schema, src, strfmt.Default)
+		schemaValidationError = errors.Wrap(validate.AgainstSchema(schema, src, strfmt.Default))
 		// don't return it yet--try to make it to custom validation stage to combine errors
 	}
 
@@ -166,7 +166,7 @@ func LoadFunctionConfig(src *yaml.RNode, api interface{}) error {
 
 	if d, ok := api.(Defaulter); ok {
 		if err := d.Default(); err != nil {
-			return err
+			return errors.Wrap(err)
 		}
 	}