Skip to content
Permalink
Browse files

fix the missing fields in all edit commands

  • Loading branch information...
Liujingfang1 committed Dec 14, 2018
1 parent f7414fe commit d0e4db74b78f5c6c7e0340c5dfb4236bffd684a7
@@ -153,6 +153,10 @@ func (mf *kustomizationFile) Read() (*types.Kustomization, error) {
return nil, err
}
k.DealWithDeprecatedFields()
msgs := k.DealWithMissingFields()
if len(msgs) > 0 {
log.Printf(strings.Join(msgs, "\n"))
}
err = mf.parseCommentedFields(data)
if err != nil {
return nil, err
@@ -78,6 +78,7 @@ func TestWriteAndRead(t *testing.T) {
if err != nil {
t.Fatalf("Couldn't read kustomization file: %v\n", err)
}
kustomization.DealWithMissingFields()
if !reflect.DeepEqual(kustomization, content) {
t.Fatal("Read kustomization is different from written kustomization")
}
@@ -172,6 +173,8 @@ func TestPreserveComments(t *testing.T) {
`# shem qing some comments
# This is some comment we should preserve
# don't delete it
apiVersion: v1
kind: Kustomization
resources:
- pod.yaml
- service.yaml
@@ -160,7 +160,7 @@ func (k *Kustomization) DealWithMissingFields() []string {
}
if k.Kind == "" {
k.Kind = KustomizationKind
msgs = append(msgs, "Fixed the missing field by adding apiKind: "+KustomizationKind)
msgs = append(msgs, "Fixed the missing field by adding kind: "+KustomizationKind)
}
return msgs
}

0 comments on commit d0e4db7

Please sign in to comment.
You can’t perform that action at this time.