make kustomize edit keep yaml structure and comments

[pwittrock]

kustomize edit drops kustomization.yaml structure and comments due to the serialization

Rebasing on to kyaml/yaml would address this.

Example:

Change this to read using the kyaml/yaml libraries:

• https://github.com/kubernetes-sigs/kustomize/blob/master/kustomize/internal/commands/edit/add/addbase.go#L51
• https://github.com/kubernetes-sigs/kustomize/blob/master/kyaml/yaml/types.go#L99

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[bat79a]

I think that I have similar probleme where my bases value is removed.

Here is my original file :

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

bases:
- ../../base/
namespace: dev

patchesStrategicMerge:
- configmap-patch.yml

images:
- name: my_image
  newName: my_image
  newTag: 0.1.0

I edit the image tag with this command :

 kustomize edit set image my_image=my_image:2.0.0

Here is the final file who doesn't work, because the bases attribute replaced by the ressources attribute :

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: dev

patchesStrategicMerge:
- configmap-patch.yml

images:
- name: my_image
  newName: my_image
  newTag: 2.0.0
resources:
- ../../base/

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jp19214]

/reopen

[k8s-ci-robot]

@jp19214: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jp19214]

I think it's valuable to to be able to keep comments when kustomize edit command is used, especially when the root kustomization.yaml file gets bigger. Please consider reopening this issue

[stormqueen1990]

/reopen
/lifecycle frozen
/triage accepted
/kind bug

[k8s-ci-robot]

@stormqueen1990: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen
/triage accepted
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.