Skip to content

/metrics-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the securityContext #337

Merged
merged 1 commit into from Nov 7, 2019
+1 −0
Merged

Update the securityContext #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
3f7c8ac
Update the securityContext
andrewkaczynski Oct 31, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Loading status checks…

Update the securityContext 

On order to avoid errors in Pod Security Policy enabled clusters, it is required to add runAsUser statement. The original one is not working with EKS  1.14
  • Loading branch information
@andrewkaczynski
andrewkaczynski committed Oct 31, 2019
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
commit 3f7c8ac86d8db3c965a871afbba8ffebde9c075e
1 deploy/1.8+/metrics-server-deployment.yaml
View file
@@ -40,6 +40,7 @@ spec:
securityContext:

This comment has been minimized.

Sign in to view
Copy link
@vjdhama

vjdhama Oct 31, 2019

Contributor

I think we can align with helm chart defaults on securityContext, cause it works and adds more options.

https://github.com/helm/charts/blob/master/stable/metrics-server/values.yaml#L81
readOnlyRootFilesystem: true
runAsNonRoot: true
runAsUser: 1000
imagePullPolicy: Always
volumeMounts:
- name: tmp-dir
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.