Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the securityContext #337

Merged
merged 1 commit into from Nov 7, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Update the securityContext

On order to avoid errors in Pod Security Policy enabled clusters, it is required to add runAsUser statement. The original one is not working with EKS  1.14
  • Loading branch information
andrewkaczynski committed Oct 31, 2019
commit 3f7c8ac86d8db3c965a871afbba8ffebde9c075e
@@ -40,6 +40,7 @@ spec:
securityContext:

This comment has been minimized.

Copy link
@vjdhama

vjdhama Oct 31, 2019

Contributor

I think we can align with helm chart defaults on securityContext, cause it works and adds more options.

https://github.com/helm/charts/blob/master/stable/metrics-server/values.yaml#L81

readOnlyRootFilesystem: true
runAsNonRoot: true
runAsUser: 1000
imagePullPolicy: Always
volumeMounts:
- name: tmp-dir
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.