Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to hide notes #83

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@saschagrunert
Copy link
Member

commented Jul 29, 2019

This commit enables the possibility to hide notes assets from the
environment configuration. The field hidden now indicates if the asset
should be invisible, which is not configurable for now.

We separate the assets from the usual environment.ts to override the
assets only when it comes to testing. The logger has been made
independent from the environment and populates the level via
isDevMode().

If everything works as intended can be verified by using the new target
npm run start:prod.


Later on the logging verbosity as well as the assets visibility
should be configurable.

@k8s-ci-robot k8s-ci-robot requested review from marpaia and onyiny-ang Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/L label Jul 29, 2019
@saschagrunert saschagrunert force-pushed the openSUSE:environment-hidden branch from 124ed74 to e077667 Jul 31, 2019
Copy link

left a comment

/lgtm

This commit enables the possibility to hide notes assets from the
environment configuration. The field `hidden` now indicates if the asset
should be invisible, which is not configurable for now.

We separate the assets from the usual environment.ts to separate the
assets only when it comes to testing. The logger has been made
independent from the environment and populates the level via
`isDevMode()`.

If everything works as intended can be verified by using the new target
`npm run start:prod`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert force-pushed the openSUSE:environment-hidden branch from e077667 to 876a751 Aug 6, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 6, 2019
@saschagrunert

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Rebased on top of the latest master branch.

@jeefy

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8b99d93 into kubernetes-sigs:master Aug 6, 2019
11 of 14 checks passed
11 of 14 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
cla/linuxfoundation saschagrunert authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-release-notes-build-dev Job succeeded.
Details
pull-release-notes-build-prod Job succeeded.
Details
pull-release-notes-check-prettier Job succeeded.
Details
pull-release-notes-doc Job succeeded.
Details
pull-release-notes-e2e Job succeeded.
Details
pull-release-notes-lint Job succeeded.
Details
pull-release-notes-test Job succeeded.
Details
tide In merge pool.
Details
@saschagrunert saschagrunert deleted the openSUSE:environment-hidden branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.