Move env related functionality into own package and apply proper testing #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/release
xmudrii
reviewed
Mar 8, 2021
saschagrunert
force-pushed
the
env-test
branch
3 times, most recently
from
d164a1b
to
fecc7fb
Compare
The first thing we do is moving the `util/env.go` into a new sub-package `env/`. The package is now using an internal `impl` to be able to apply properly mocked unit testing which is not dependent from the machine they're running on. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first thing we do is moving the
util/env.gointo a new sub-packageenv/. The package is now using an internalimplto be able to applyproperly mocked unit testing which is not dependent from the machine
they're running on.
Godoc can be used to demonstrate the isolation of the internal package.
We only have two functions exposed via the API, whereas the underlying
implementation can be changed from within our tests.