Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for ./pkg/rest/core/fake rest client, addresses #860 Test ready to be reviewed #1113

Merged
merged 2 commits into from Aug 16, 2017

Conversation

@crmejia
Copy link
Contributor

@crmejia crmejia commented Aug 8, 2017

Closes: #860

I apologize for the new PR. I had to recreate my previous PR as I signed the CLA with a different email than the one I had setup for GitHub and my fork wouldn't reconcile.

The test is ready to be reviewed.

Copy link
Contributor

@arschles arschles left a comment

@crmejia the travis integration tests failed, so I restarted them. Generally, this LGTM so I'm marking as such

func createSingleItemStorage() NamespacedStorage {
storage := make(NamespacedStorage)
storage.Set(ns1, tipe1, name1, &servicecatalog.Broker{})
// storage.Set(ns1, tipe1, name1, &servicecatalog.Instance{})

This comment has been minimized.

@arschles

arschles Aug 14, 2017
Contributor

@crmejia remove this?

This comment has been minimized.

@crmejia

crmejia Aug 14, 2017
Author Contributor

done!

@arschles arschles added the LGTM1 label Aug 14, 2017
crmejia added 2 commits Aug 8, 2017
@crmejia crmejia force-pushed the crmejia:issue_860 branch from 7ee8311 to 282b7e4 Aug 14, 2017
@crmejia crmejia changed the title unit test for ./pkg/rest/core/fake rest client, addresses #860Test ready to be reviewed unit test for ./pkg/rest/core/fake rest client, addresses #860 Test ready to be reviewed Aug 15, 2017
@vaikas vaikas added the LGTM2 label Aug 16, 2017
@vaikas vaikas merged commit f32eec2 into kubernetes-sigs:master Aug 16, 2017
3 checks passed
3 checks passed
cla/linuxfoundation crmejia authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
service-catalog-PR-testing2 Successful presubmits. Details at https://service-catalog-jenkins.appspot.com/job/service-catalog-PR-testing2/1797/.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants