Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State in the documetation that svc-cat depends on k8s v1.13+ #2703

Conversation

@vpnachev
Copy link
Contributor

commented Sep 10, 2019

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:
Improve documentation to make it clear that service catalog requires k8s cluster of version v1.13 or newer.

Which issue(s) this PR fixes

Fixes #2678

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Welcome @vpnachev!

It looks like this is your first PR to kubernetes-sigs/service-catalog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/service-catalog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Hi @vpnachev. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpnachev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

/assign @MHBauer

@mszostok

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/ok-to-test

@mszostok

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/retest

@mszostok

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/lgtm

@MHBauer

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

The other way to do this is to massage the language so that it mentions matching the k8s support process, so two releases-ish.

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MHBauer, vpnachev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2ee8df into kubernetes-sigs:master Sep 10, 2019
12 of 13 checks passed
12 of 13 checks passed
tide Not mergeable. Needs approved label.
Details
cla/linuxfoundation vpnachev authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
pull-build-all-images-for-amd64 Job succeeded.
Details
pull-build-all-images-for-arm Job succeeded.
Details
pull-build-all-images-for-arm64 Job succeeded.
Details
pull-build-all-images-for-ppc64le Job succeeded.
Details
pull-build-all-images-for-s390x Job succeeded.
Details
pull-build-all-images-for-svcat Job succeeded.
Details
pull-service-catalog-test-e2e Job succeeded.
Details
pull-service-catalog-test-integration Job succeeded.
Details
pull-service-catalog-test-unit Job succeeded.
Details
@vpnachev vpnachev deleted the vpnachev:documentation/bump-k8s-version-requirement branch Sep 10, 2019
@vpnachev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

The other way to do this is to massage the language so that it mentions matching the k8s support process, so two releases-ish.

@MHBauer
Actually, it should be a compatibility matrix like the client-go one, because svc-cat mostly increases the patch numbers, not the minor. For example, it is hard to define which are the supported k8s versions for svc-cat v0.1.x which was initially released 2 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.