Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gke provider and docs how to run e2e tests #32

Merged
merged 1 commit into from Jan 8, 2019

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Jan 7, 2019

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2019
@cofyc
Copy link
Member Author

cofyc commented Jan 7, 2019

/assign @msau42

@msau42
Copy link
Contributor

msau42 commented Jan 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@msau42
Copy link
Contributor

msau42 commented Jan 7, 2019

/retest

1 similar comment
@cofyc
Copy link
Member Author

cofyc commented Jan 8, 2019

/retest

- docs on how to run e2e tests
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@cofyc
Copy link
Member Author

cofyc commented Jan 8, 2019

I've made a mistake before. It passed now.

@msau42
Copy link
Contributor

msau42 commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit bb4df2d into kubernetes-sigs:master Jan 8, 2019
@cofyc cofyc deleted the fix27 branch January 15, 2019 07:24
davidmccormick pushed a commit to davidmccormick/sig-storage-local-static-provisioner that referenced this pull request Mar 31, 2021
Support gke provider and docs how to run e2e tests
dobsonj pushed a commit to dobsonj/sig-storage-local-static-provisioner that referenced this pull request Feb 7, 2022
…g-.ci-operator.yaml-`build_root_image`-from-openshift/release

Updating .ci-operator.yaml `build_root_image` from openshift/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to run e2e tests in development
3 participants