New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for CSI volume spec in PVUpdated method #1013
Add check for CSI volume spec in PVUpdated method #1013
Conversation
|
Started Vanilla block pre-checkin pipeline... Build Number: 105 |
|
This change needs to be cherry-picked to 2.3 & 2.2. |
|
Change looks good to me. |
|
The 1 failure is a known intermittent failure which is tracked internally. cc: @divyenpatel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel, gohilankit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
|
…k-2.2 Cherry-pick PR (#1013) to rel 2.2 - Add check for CSI volume spec in PVUpdated method
What this PR does / why we need it:
This PR is adding CSI check for volume spec in metadatasyncer. Currently we are assuming that the volumes are always CSI volumes, however for migrated volumes the spec does not contain CSI field and hence a crash was observed during CSI migration testing.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Before:
Performed same steps after the fix and no crash was observed
&
Running e2e pipelines
Special notes for your reviewer:
Release note: