fix node discovery when nodes are not upgraded to v2.5.0 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
chethanv28
requested changes
Sep 15, 2022
divyenpatel
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
shalini-b
requested changes
Sep 15, 2022
divyenpatel
force-pushed
the
fix-node-discovery-when-nodes-not-upgraded
branch
3 times, most recently
from
da0dd70 to
a7c5d08
Compare
divyenpatel
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
divyenpatel
force-pushed
the
fix-node-discovery-when-nodes-not-upgraded
branch
from
a7c5d08 to
1c77bc9
Compare
|
@chethanv28 @shalini-b I have addressed your review comments and also performed e2e upgrade validation for this PR. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel, shalini-b The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adikul30
pushed a commit
to adikul30/vsphere-csi-driver
that referenced
this pull request
Sep 22, 2022
divyenpatel
added a commit
to divyenpatel/vsphere-csi-driver
that referenced
this pull request
Sep 22, 2022
divyenpatel
added a commit
to divyenpatel/vsphere-csi-driver
that referenced
this pull request
Sep 22, 2022
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 22, 2022
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR helps fix node discovery when nodes are not upgraded to use v2.5.0 release of the driver, but CSI controller is upgraded to use v2.5.0
This is happening on TKGi platform during upgrade. After upgrading master node to use v2.5.0 bits, node discovery is failing as worker nodes are not yet upgraded and still have Node name as Node ID in the CSINodes object. For this case, we need to fall back and discover node using the ProviderID set on the Node object.
This PR is needed along with #1966
Testing done:
TKGI team has validated upgrading CSI driver with this change.
Special notes for your reviewer:
Release note: