Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick windows support fixes to release 2.7 #2005

Conversation

divyenpatel
Copy link
Member

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

windows support fixes

divyenpatel and others added 2 commits September 26, 2022 13:46
It doesn't work correctly with windows pathnames because they start with c: and
the parser thinks that's a user name.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@divyenpatel divyenpatel changed the title Cherry pick windows support fixes release 2.7 Cherry pick windows support fixes to release 2.7 Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2022
@gohilankit
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, gohilankit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [divyenpatel,gohilankit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4176a61 into kubernetes-sigs:release-2.7 Sep 26, 2022
adikul30 pushed a commit to adikul30/vsphere-csi-driver that referenced this pull request Oct 26, 2022
* fix GetSystemUUID to return correct VM UUID for Windows Nodes (kubernetes-sigs#1996)

* Eliminate use of problematic url.Parse() (kubernetes-sigs#1998)

It doesn't work correctly with windows pathnames because they start with c: and
the parser thinks that's a user name.

Co-authored-by: cphvmware <111934873+cphvmware@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants