New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix vsphere backward compatibility issue #409
fix vsphere backward compatibility issue #409
Conversation
b01edf7
to
85b9cbc
Compare
Can one of the admins verify this patch? |
85b9cbc
to
1f6b354
Compare
I have only minor comments. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3e27dd4
to
1e9e320
Compare
The change looks good except for a minor comment above. Can you run E2E tests? It will be nice if we test this code works fine on vSphere 6.7U3 before merge. Btw, can you also squash commit this PR? |
731db74
to
2f4ddef
Compare
@SandeepPissay I have executed the Full sync delete volume test on 67u3 and 7.0 setup with images provided by @divyenpatel, here are the logs. |
jtest block-vanilla |
jtest file-vanilla |
Started Vanilla block pipeline... |
Started vanilla file pipeline... |
|
|
jtest block-vanilla |
jtest file-vanilla |
Started vanilla file pipeline... |
Started Vanilla block pipeline... |
|
|
/lgtm |
What this PR does / why we need it:
This PR is fixing the v2.0.0 backward compatibility issue observed on the vSphere 67 release.
Which issue this PR fixes
fixes #408
Special notes for your reviewer:
Testing is done.
@marunachalam has helped verify this fix on vSphere 67 latest patch as well as vSphere 7.0
All full sync related issues are resolved on vSphere 67 vCenter.
Test logs
VC 6.7- https://gist.github.com/marunachalam/cc257dfa77479f08a4ba2af24d802791
VC 7.0 - https://gist.github.com/marunachalam/b86d999e757fa3f72678f342949f86a2
Release note: