New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable X_CSI_SPEC_DISABLE_LEN_CHECK for CSI controller #801
Disable X_CSI_SPEC_DISABLE_LEN_CHECK for CSI controller #801
Conversation
|
jtest block-vanilla |
|
Started Vanilla block pipeline... |
|
|
jtest block-vanilla |
|
Started Vanilla block pipeline... |
|
|
jtest block-vanilla |
|
Started Vanilla block pipeline... |
|
|
I see we are not updating - https://github.com/kubernetes-sigs/vsphere-csi-driver/tree/master/manifests/dev/vsphere-7.0u2/vanilla We will be removing the following directories, so if you can just update this in the 7.0u2 folder, it is fine. https://github.com/kubernetes-sigs/vsphere-csi-driver/tree/master/manifests/dev/vsphere-67u3 |
I have updated yaml in 70u2 folder. Also I am keeping the changes in 6.7u3, 7.0 and 7.0u1 since the PR to consolidate yamls will eventually remove the folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
When customers create VCP volumes with long datastore names & with spbm policy, it is observed that volume names canend up with more than 128 characters. Now when customers move to CSI using the CSI migration feature, pod creation fails with the below error:
For ex:
[Very-long-vsanDatastore-name] 4bb55260-de8a-c071-913b-020049bb8da4/kubernetes-dynamic-pvc-f8464f80-e90f-4356-ba4f-480fd47e7ea2.vmdkrpc error: code = InvalidArgument desc = exceeds size limit: VolumeId: max=128, size=132
See
https://github.com/kubernetes/kubernetes/issues/101153for more details.In vSphere CSI driver we can address this issue by disabling
X_CSI_SPEC_DISABLE_LEN_CHECKENV in the deployment yaml file.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Before:
After:
Release note: