Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed detach volume error handling #840

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented May 5, 2021

What this PR does / why we need it:

This PR is fixing detach volume error handling to cover following cases.

  1. During detach operation if it is observed that Node VM is deleted from the vCenter inventory, detach will be marked as successful, instead of failing the detach operation.
  2. During detach operation if NotFound fault is returned, we need to check VM devices and ensure volume is not attached to the Node VM and for all other faults we need to fail the detach volume operation.

Special notes for your reviewer:
Testing Done - Yes

Verified following cases

  1. Detach passes when node VM is deleted.
  2. Detach fails when FCD is attached to node VM, but fcd is not registered as CNS volume.
  3. Detach passes when FCD is not attached to node VM, but fcd is not registered as CNS volume.
  4. Detach passe when FCD is attached to node VM, and FCD is registered as CNS volume.

Release note:

fixed detach volume error handling

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@divyenpatel
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2021
@divyenpatel
Copy link
Member Author

jtest wcp

@svcbot-qecnsdp
Copy link

Started WCP block pipeline...

@divyenpatel
Copy link
Member Author

jtest gc

@svcbot-qecnsdp
Copy link

Started GC block pipeline...

@divyenpatel
Copy link
Member Author

Block and File tests already passed and results posted at
#837 (comment)
#837 (comment)

@svcbot-qecnsdp
Copy link

WCP build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 
SSSSS
Ran 31 of 169 Specs in 6141.192 seconds
SUCCESS! -- 31 Passed | 0 Failed | 0 Pending | 138 Skipped
PASS

Ginkgo ran 1 suite in 1h42m41.825680676s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/github-csi-wcp-CICD/Results/631/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link

GC build status: FAILURE 
Stage before exit: deploy-gc-testbed 

Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. v2.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants