New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed detach volume error handling #840
fixed detach volume error handling #840
Conversation
|
/ok-to-test |
|
jtest wcp |
|
Started WCP block pipeline... |
|
jtest gc |
|
Started GC block pipeline... |
|
Block and File tests already passed and results posted at |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR is fixing detach volume error handling to cover following cases.
NotFoundfault is returned, we need to check VM devices and ensure volume is not attached to the Node VM and for all other faults we need to fail the detach volume operation.Special notes for your reviewer:
Testing Done - Yes
Verified following cases
Release note: