Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading photon to 4.0 #866

Merged

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented May 14, 2021

What this PR does / why we need it:
upgrading photon to 4.0

Special notes for your reviewer:
Here is the temporary image created to validate volume lifecycle operations (Create, attach, mount, unmount, detach and delete) with photon 4.0 as the base image.

  • docker.io/vcsidev/vsphere-csi:divyen-866
  • docker.io/vcsidev/syncer:divyen-866

No issue observed during testing.

Output of building base driver image with Photon 4.0

divyenp@divyenp-a02 driver-base % ls
Dockerfile	Makefile
divyenp@divyenp-a02 driver-base % make

% make
docker build -t gcr.io/cloud-provider-vsphere/extra/csi-driver-base:v2.1.0-rc.1-653-g5521e92a .
[+] Building 12.1s (7/7) FINISHED                                                                                                                                                                   
 => [internal] load build definition from Dockerfile                                                                                                                                           0.0s
 => => transferring dockerfile: 828B                                                                                                                                                           0.0s
 => [internal] load .dockerignore                                                                                                                                                              0.0s
 => => transferring context: 2B                                                                                                                                                                0.0s
 => [internal] load metadata for docker.io/library/photon:4.0                                                                                                                                  2.2s
 => [auth] library/photon:pull token for registry-1.docker.io                                                                                                                                  0.0s
 => [1/2] FROM docker.io/library/photon:4.0@sha256:6b6060b812ba9c11c5abcaf6f9188131ba11f62313e516948391012d4820e237                                                                            3.6s
 => => resolve docker.io/library/photon:4.0@sha256:6b6060b812ba9c11c5abcaf6f9188131ba11f62313e516948391012d4820e237                                                                            0.0s
 => => sha256:6b6060b812ba9c11c5abcaf6f9188131ba11f62313e516948391012d4820e237 547B / 547B                                                                                                     0.0s
 => => sha256:7e5a6104e8c62dfbf46a182e8fdaf7020154b78df3d843ad47f090a87435065a 529B / 529B                                                                                                     0.0s
 => => sha256:efe302ef660dc9d74b383db396141b3915a5a847fd2577444a7b6dde1cd5d536 1.81kB / 1.81kB                                                                                                 0.0s
 => => sha256:8c546dbfb0605cb8268489289c1ddce53a335acb640097fc2ac45484b66aa543 15.78MB / 15.78MB                                                                                               2.7s
 => => extracting sha256:8c546dbfb0605cb8268489289c1ddce53a335acb640097fc2ac45484b66aa543                                                                                                      0.5s
 => [2/2] RUN tdnf -y upgrade && tdnf clean all                                                                                                                                                6.2s
 => exporting to image                                                                                                                                                                         0.0s
 => => exporting layers                                                                                                                                                                        0.0s
 => => writing image sha256:8f6cfaf54ce3ea5138433be3d5454d3155aaaa46c4101ae685bd50eaae220b5b                                                                                                   0.0s
 => => naming to gcr.io/cloud-provider-vsphere/extra/csi-driver-base:v2.1.0-rc.1-653-g5521e92a                                                                                                 0.0s
docker tag gcr.io/cloud-provider-vsphere/extra/csi-driver-base:v2.1.0-rc.1-653-g5521e92a gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest                                                 

Release note:

upgrading photon to 4.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2021
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 18, 2021
@chethanv28
Copy link
Collaborator

chethanv28 commented May 18, 2021

Performed basic volume lifecycle operation. No issue observed

Can you paste some testing results so that it will be captured in the PR details
or we can run e2e pipeline ?

@divyenpatel
Copy link
Member Author

Performed basic volume lifecycle operation. No issue observed

Can you paste some testing results so that it will be captured in the PR details
or we can run e2e pipeline ?

I do not have testing results. I have the setup on which I have created a statefulset and performed a few scale up and scale down operations.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe89a40 into kubernetes-sigs:master May 18, 2021
@@ -52,6 +52,7 @@ LABEL "maintainers"="Divyen Patel <divyenp@vmware.com>, Sandeep Pissay Srinivasa
# nfs-utils : The nfs-utils package contains simple nfs client service.
# util-linux : Utilities for handling file systems, consoles, partitions.
# e2fsprogs : The E2fsprogs package contains the utilities for handling the ext file system.
# xfsprogs : The xfsprogs package contains administration and debugging tools for the XFS file system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we test out some apps with XVF file system, we can call out the xfs support as alpha in our docs. Alpha means that it is dev qualified only, no GSS support and use it at your own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants