Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests for ARM64 #44

Merged
merged 1 commit into from Jan 28, 2021
Merged

Conversation

@hakman
Copy link
Member

@hakman hakman commented Nov 13, 2020

Ref: #34 (comment)

Skipping Go 1.14 because it was never used in any k8s release.
The -race flag is not supported on linux/arm.
Tests should fail until #42 is merged.

@hakman
Copy link
Member Author

@hakman hakman commented Nov 13, 2020

Loading

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 Nov 13, 2020
@k8s-ci-robot
Copy link

@k8s-ci-robot k8s-ci-robot commented Nov 13, 2020

@hakman: GitHub didn't allow me to request PR reviews from the following users: afbjorklund, zhsj.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @neolit123 @afbjorklund @zhsj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Loading

@hakman hakman force-pushed the travisci-arm64 branch from 075a82d to 3f70512 Nov 13, 2020
@hakman hakman force-pushed the travisci-arm64 branch 6 times, most recently from 8b32345 to 932e0c7 Nov 13, 2020
Copy link
Member

@neolit123 neolit123 left a comment

/lgtm
thanks!

Loading

@hakman
Copy link
Member Author

@hakman hakman commented Nov 13, 2020

Thanks @neolit123. Will wait for #42 to merge and rebase.

Loading

@hakman
Copy link
Member Author

@hakman hakman commented Nov 17, 2020

/assign @liggitt

Loading

.travis.yml Outdated
script:
- diff -u <(echo -n) <(gofmt -d *.go)
- diff -u <(echo -n) <(golint $(go list -e ./...) | grep -v YAMLToJSON)
- GO111MODULE=on go vet .
- GO111MODULE=on go test -v -race ./...
- if [[ $TRAVIS_CPU_ARCH == "arm64" ]]; then
GOARCH=arm GOARM=7 GO111MODULE=on go test -v ./...;
Copy link

@liggitt liggitt Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you describe what this is doing? I'm surprised setting GOARCH explicitly is required

Loading

Copy link

@afbjorklund afbjorklund Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is building and testing the 32-bit binary (armv7), so it's like a two-for-one (arm64+arm32)

Loading

Copy link
Member Author

@hakman hakman Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea in the original issue was to use the CI setup to run the ARM v7 tests also, as it should be compatible with both v7 and v8.

In case the TravisCI CPU is ARM64, an ARM v7 test is also run, but without -race, which is not supported.

Loading

@hakman hakman requested a review from liggitt Nov 21, 2020
@hakman hakman force-pushed the travisci-arm64 branch from 932e0c7 to 396c684 Jan 28, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch 2 times, most recently from 9e95499 to 52890f4 Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch 3 times, most recently from 02d0e46 to 81e230f Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch 2 times, most recently from 840c2b1 to 38c293b Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch from 38c293b to 3cc309c Jan 28, 2021
@hakman
Copy link
Member Author

@hakman hakman commented Jan 28, 2021

@neolit123 @liggitt as TravisCI was replaced by GitHub actions, I updated the PR to only test ARM64, which is missing from GitHub actions for now (should be available sometime in Q1).

Loading

@hakman hakman requested a review from neolit123 Jan 28, 2021
@dims
Copy link
Member

@dims dims commented Jan 28, 2021

thanks @hakman

/approve
/lgtm

Loading

@k8s-ci-robot
Copy link

@k8s-ci-robot k8s-ci-robot commented Jan 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 11e43d4 into kubernetes-sigs:master Jan 28, 2021
5 of 6 checks passed
Loading
@hakman hakman deleted the travisci-arm64 branch Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants