Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github-actions CI #50

Merged
merged 1 commit into from Jan 26, 2021
Merged

Conversation

@longwuyuan
Copy link

@longwuyuan longwuyuan commented Jan 26, 2021

This PR attempts to resolve #48

@longwuyuan
Copy link
Author

@longwuyuan longwuyuan commented Jan 26, 2021

@dims @palnabarun new clean pr here

Loading

@dims
Copy link
Member

@dims dims commented Jan 26, 2021

Looks like the GH check passed here : https://github.com/longwuyuan/yaml/actions/runs/512198272

/approve
/lgtm

Loading

@k8s-ci-robot
Copy link

@k8s-ci-robot k8s-ci-robot commented Jan 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Loading

@k8s-ci-robot k8s-ci-robot merged commit 9f315c2 into kubernetes-sigs:master Jan 26, 2021
2 of 3 checks passed
Loading
build:
strategy:
matrix:
go-versions: [1.12.x, 1.13.x, 1.14.x]
Copy link
Member

@dims dims Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add newer go 1.15.x in a follow up PR

Loading

Copy link
Author

@longwuyuan longwuyuan Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will get on it right away

Loading

Copy link
Author

@longwuyuan longwuyuan Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a different note ;

  • Travis CI was explicit about distro and release (ubuntu-xenial) and the github-actions is now using "ubuntu-latest" which is translating to xenial for now. But the GH-Actions is also showing this message ;
Ubuntu-latest workflows will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816

Does this require any attention or is "ubuntu-latest" ok when GH starts using focal

Loading

Copy link
Author

@longwuyuan longwuyuan Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please advise if "only" add 1.15.x or remove 1.12.x as well. thnx

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants