New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom AWS region overrides #1707 #1717
Conversation
…y #70588" into cluster-autoscaler: Modify k8s cloudprovider aws like kubernetes but expose key type/methods for use by cluster-autoscaler aws_manager.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please sign CLA and update the PR title to correctly reflect the content. |
Also, included the text, Closes #1707 |
@@ -30,6 +30,7 @@ import ( | |||
|
|||
"github.com/aws/aws-sdk-go/aws" | |||
"github.com/aws/aws-sdk-go/aws/ec2metadata" | |||
//"github.com/aws/aws-sdk-go/aws/endpoints" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't introduce commented out imports and code unless there's a very good reason for it (state it in comment if this is the case).
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:
Modified k8s cloudprovider aws like kubernetes but exposed key type/methods for use by cluster-autoscaler aws_manager.
Closes #1707
Which issue(s) this PR fixes:
Fixes #1707