Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom AWS region overrides #1707 #1717

Closed
wants to merge 2 commits into from

Conversation

jottofar
Copy link

@jottofar jottofar commented Feb 23, 2019

Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:
Modified k8s cloudprovider aws like kubernetes but exposed key type/methods for use by cluster-autoscaler aws_manager.

Closes #1707

Which issue(s) this PR fixes:

Fixes #1707

…y #70588" into cluster-autoscaler:

Modify k8s cloudprovider aws like kubernetes but expose key type/methods for use by cluster-autoscaler aws_manager.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aleksandra-malinowska

If they are not already assigned, you can assign the PR to them by writing /assign @aleksandra-malinowska in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwielgus
Copy link
Contributor

Please sign CLA and update the PR title to correctly reflect the content.

@cuppett
Copy link
Contributor

cuppett commented Feb 24, 2019

Also, included the text, Closes #1707

@jottofar jottofar changed the title Bz1644084 Allow custom AWS region overrides #1707 Feb 24, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 24, 2019
@@ -30,6 +30,7 @@ import (

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/ec2metadata"
//"github.com/aws/aws-sdk-go/aws/endpoints"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't introduce commented out imports and code unless there's a very good reason for it (state it in comment if this is the case).

@jottofar jottofar closed this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom AWS region overrides
6 participants