Skip to content

feat(cluster-autoscaler/exoscale): add support for --nodes#6771

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
WhizUs:feat/exoscale-provider-maxnodeslimit-per-nodepool
Sep 25, 2024
Merged

feat(cluster-autoscaler/exoscale): add support for --nodes#6771
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
WhizUs:feat/exoscale-provider-maxnodeslimit-per-nodepool

Conversation

@thomasstxyz
Copy link
Copy Markdown
Contributor

@thomasstxyz thomasstxyz commented Apr 25, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

cluster-autoscaler/exoscale: This PR adds support for configuration of minimum and maximum size of specified node groups via the --nodes=<min>:<max>:<nodepool-name> flag.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer April 25, 2024 18:39
@k8s-ci-robot k8s-ci-robot added the area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 25, 2024

Hi @thomasstxyz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
@Sapd
Copy link
Copy Markdown

Sapd commented Apr 26, 2024

FYI @pierre-emmanuelJ @7fELF @PhilippeChepy

pierre-emmanuelJ
pierre-emmanuelJ approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this change! Nice work, it's clear :)

@pierre-emmanuelJ
Copy link
Copy Markdown
Contributor

pierre-emmanuelJ commented May 8, 2024

/approve

@pierre-emmanuelJ
Copy link
Copy Markdown
Contributor

pierre-emmanuelJ commented May 8, 2024

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 8, 2024

@pierre-emmanuelJ: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thomasstxyz thomasstxyz force-pushed the feat/exoscale-provider-maxnodeslimit-per-nodepool branch from f48f832 to 721c4e4 Compare May 8, 2024 15:18
@thomasstxyz
Copy link
Copy Markdown
Contributor Author

thomasstxyz commented May 8, 2024

Please review and approve @gjtempleton @feiskyer @BigDarkClown thanks

@thomasstxyz
Copy link
Copy Markdown
Contributor Author

thomasstxyz commented May 23, 2024

/assign @gjtempleton

@PhilippeChepy
Copy link
Copy Markdown
Contributor

PhilippeChepy commented May 28, 2024

/approve

@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented May 29, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2024
Shubham82
Shubham82 reviewed May 29, 2024
View reviewed changes
Comment thread charts/cluster-autoscaler/Chart.yaml Outdated
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
type: application
version: 9.37.0
version: 9.37.1
Copy link
Copy Markdown
Contributor

@Shubham82 Shubham82 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasstxyz
This is a new feature, please make this a minor version bump.

Copy link
Copy Markdown
Contributor Author

@thomasstxyz thomasstxyz Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shubham82 Done.

@thomasstxyz thomasstxyz force-pushed the feat/exoscale-provider-maxnodeslimit-per-nodepool branch from 721c4e4 to 3b5ec0d Compare June 17, 2024 08:32
@thomasstxyz thomasstxyz requested a review from Shubham82 June 17, 2024 09:02
@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Jun 17, 2024

Thanks @thomasstxyz
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2024
@thomasstxyz
Copy link
Copy Markdown
Contributor Author

thomasstxyz commented Jun 26, 2024

@Shubham82 is there anything to do from my side?

@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Jun 26, 2024

@Shubham82 is there anything to do from my side?

For me, it looks good.
To merge it, PR needs to be approved by the approver (/approve label).

@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Jun 26, 2024

CC @gjtempleton could you please approve this PR so it will be merged?

Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Sep 24, 2024

@thomasstxyz, please resolve the merge conflict.

@thomasstxyz thomasstxyz force-pushed the feat/exoscale-provider-maxnodeslimit-per-nodepool branch from 3b5ec0d to 1d605b1 Compare September 24, 2024 08:14
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2024
@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Sep 24, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2024
@thomasstxyz
feat(cluster-autoscaler/exoscale): add support for --nodes
5abbb4a 
Signed-off-by: Thomas Stadler <thomas.stadler@whizus.com>
@thomasstxyz thomasstxyz force-pushed the feat/exoscale-provider-maxnodeslimit-per-nodepool branch from 1d605b1 to 5abbb4a Compare September 24, 2024 11:19
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2024
@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Sep 25, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@Shubham82
Copy link
Copy Markdown
Contributor

Shubham82 commented Sep 25, 2024

Hi @gjtempleton @jackfrancis
Need your approval to merge this PR.

Thanks!

@gjtempleton
Copy link
Copy Markdown
Member

gjtempleton commented Sep 25, 2024

Thanks for this, good to see.
LGTM on the helm chart side.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, PhilippeChepy, pierre-emmanuelJ, sauterp, thomasstxyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 19fe7ab into kubernetes:master Sep 25, 2024
@dev-dsp
Copy link
Copy Markdown

dev-dsp commented Oct 4, 2024

Is it nodepool-name? Or nodepool-id? Or instancepool-id?

@thomasstxyz
Copy link
Copy Markdown
Contributor Author

thomasstxyz commented Oct 6, 2024

Is it nodepool-name? Or nodepool-id? Or instancepool-id?

nodepool-name

@thomasstxyz thomasstxyz deleted the feat/exoscale-provider-maxnodeslimit-per-nodepool branch October 4, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@Shubham82 Shubham82 Awaiting requested review from Shubham82

2 more reviewers

@pierre-emmanuelJ pierre-emmanuelJ pierre-emmanuelJ approved these changes

@sauterp sauterp sauterp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gjtempleton gjtempleton

@Shubham82 Shubham82

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@thomasstxyz @k8s-ci-robot @Sapd @pierre-emmanuelJ @PhilippeChepy @Shubham82 @gjtempleton @dev-dsp @sauterp