[stable/kong] Add a chart for Kong #3150

shashiranjan84 · 2017-12-26T07:14:50Z

Chart deploys Kong and its backing datastore either Cassandra or
PostgreSql(default)
Uses official Kong Docker image

Note: Opening this new PR instead of #3031.

k8s-ci-robot · 2017-12-26T07:14:53Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

shashiranjan84 · 2017-12-26T07:21:07Z

/assign @unguiculus

shashiranjan84 · 2017-12-26T07:22:50Z

I have updated the the labels and made few more changes as advised in best practices guide.

unguiculus

Thanks for the PR. I did an initial review.

unguiculus · 2018-01-07T17:23:19Z

stable/kong/Chart.yaml

Add appVersion field.

unguiculus · 2018-01-07T17:24:17Z

stable/kong/templates/NOTES.txt

Add release label to selector.

unguiculus · 2018-01-07T17:24:42Z

stable/kong/templates/NOTES.txt

Add release label to selector.

unguiculus · 2018-01-07T17:25:02Z

stable/kong/templates/NOTES.txt

Add release label to selector.

unguiculus · 2018-01-07T17:25:08Z

stable/kong/templates/NOTES.txt

Add release label to selector.

unguiculus · 2018-01-07T17:26:32Z

stable/kong/templates/migrations.yaml

Only app and release labels should go here.

unguiculus · 2018-01-07T17:33:06Z

stable/kong/templates/deployment.yaml

It doesn't look like you have real components in your chart. There is only a single deployment. Usually, components are used to identify multiple deployments in a chart and then are added to label selectors. This is not the case here. Do they server any special purpose?

unguiculus · 2018-01-07T17:36:56Z

stable/kong/README.md

kong.database.type is not set anywhere but mentioned here.

unguiculus · 2018-01-07T17:42:13Z

stable/kong/values.yaml

It doesn't make sense to reproduce the whole Cassandra and Postgres values files here.

unguiculus · 2018-01-07T17:44:14Z

stable/kong/values.yaml

You should not added a second field for the DB password. There is already postgresql.postgresPassword. Also, by default, a random password is generated. Let's keep it that way.

shashiranjan84 · 2018-01-08T05:24:45Z

@unguiculus thanks for review. I will make the changes you advised. Please expect some delay as I am travelling and have limited internet connectivity.

- Chart deploys Kong and its backing datastore either Cassandra or PostgreSql(default) - Uses official [Kong](https://hub.docker.com/_/kong/) Docker image

shashiranjan84 · 2018-01-08T07:38:08Z

@unguiculus please review.

unguiculus

Please don't squash commits. They will be squashed upon merge anyways.

unguiculus · 2018-01-11T18:45:08Z

stable/kong/README.md

+
+## Prerequisites
+
+- Kubernetes 1.6+ with Beta APIs enabled.


1.8+

We offically support the current and previous minor versions.

unguiculus · 2018-01-11T18:47:06Z

stable/kong/templates/deployment.yaml

@@ -0,0 +1,88 @@
+apiVersion: extensions/v1beta1


Use apps/v1beta2

unguiculus · 2018-01-11T18:48:22Z

stable/kong/values.yaml

+  enabled: true
+  postgresUser: kong
+  postgresPassword: kong
+  postgresDatabase: kong


Comment this out so the password is auto-generated by default.

unguiculus · 2018-01-13T14:15:00Z

/ok-to-test

unguiculus · 2018-01-13T16:25:29Z

stable/kong/templates/deployment.yaml

+  replicas: {{ .Values.replicaCount }}
+  selector:
+    matchLabels:
+      app: {{ template "kong.name" . }}


Add release label to selector.

shashiranjan84 · 2018-01-18T13:28:00Z

@unguiculus are we still waiting on something?

shashiranjan84 · 2018-01-23T18:57:44Z

ping @unguiculus

unguiculus · 2018-01-27T13:25:58Z

stable/kong/templates/migrations.yaml

+      - name: {{ template "kong.name" . }}-migrations
+        image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+        imagePullPolicy: {{ .Values.image.pullPolicy }}
+        env:


For consistency, don't indent this list.

makes sense, @unguiculus I fixed it.

unguiculus · 2018-01-27T13:26:36Z

/ok-to-test

unguiculus · 2018-01-27T14:08:43Z

/lgtm

k8s-ci-robot · 2018-01-27T14:08:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shashiranjan84, unguiculus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [unguiculus]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-ci-robot assigned unguiculus Dec 26, 2017

unguiculus suggested changes Jan 7, 2018

View reviewed changes

[stable/kong] Add a chart for Kong

6f50d7e

- Chart deploys Kong and its backing datastore either Cassandra or PostgreSql(default) - Uses official [Kong](https://hub.docker.com/_/kong/) Docker image

unguiculus suggested changes Jan 11, 2018

View reviewed changes

Deployment apiversion update

22d778c

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2018

added missing selector field

43f5477

unguiculus suggested changes Jan 13, 2018

View reviewed changes

added release to selector

5face1e

update to support Kong v0.12.1

85319ce

unguiculus suggested changes Jan 27, 2018

View reviewed changes

fix indentation

fc86345

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2018

k8s-ci-robot merged commit 356c348 into helm:master Jan 27, 2018

[stable/kong] Add a chart for Kong #3150

[stable/kong] Add a chart for Kong #3150

Uh oh!

Conversation

shashiranjan84 commented Dec 26, 2017

Uh oh!

k8s-ci-robot commented Dec 26, 2017

Uh oh!

shashiranjan84 commented Dec 26, 2017

Uh oh!

shashiranjan84 commented Dec 26, 2017

Uh oh!

unguiculus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shashiranjan84 commented Jan 8, 2018

Uh oh!

shashiranjan84 commented Jan 8, 2018

Uh oh!

unguiculus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unguiculus commented Jan 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shashiranjan84 commented Jan 18, 2018

Uh oh!

shashiranjan84 commented Jan 23, 2018

Uh oh!

unguiculus Jan 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unguiculus commented Jan 27, 2018

Uh oh!

unguiculus commented Jan 27, 2018

Uh oh!

k8s-ci-robot commented Jan 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

unguiculus Jan 27, 2018 •

edited

Loading