Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SERVICE_FORCE_BACKEND_ENI env for serverless kubernetes #94

Merged
merged 2 commits into from Sep 23, 2019

Conversation

@jovizhangwei
Copy link
Contributor

jovizhangwei commented Sep 18, 2019

Signed-off-by: xianwei.zw xianwei.zw@alibaba-inc.com

Signed-off-by: xianwei.zw <xianwei.zw@alibaba-inc.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 18, 2019

Welcome @jovizhangwei!

It looks like this is your first PR to kubernetes/cloud-provider-alibaba-cloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-alibaba-cloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 18, 2019

Hi @jovizhangwei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aoxn

This comment has been minimized.

Copy link
Contributor

aoxn commented Sep 18, 2019

/ok-to-test

@aoxn

This comment has been minimized.

Copy link
Contributor

aoxn commented Sep 23, 2019

/LGTM
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 23, 2019
@aoxn

This comment has been minimized.

Copy link
Contributor

aoxn commented Sep 23, 2019

/ok-to-test

@aoxn

This comment has been minimized.

Copy link
Contributor

aoxn commented Sep 23, 2019

/LGTM
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 23, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoxn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 96531fb into kubernetes:master Sep 23, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation jovizhangwei authorized
Details
pull-cloud-provider-alibaba-cloud-check Job succeeded.
Details
pull-cloud-provider-alibaba-cloud-unit-test Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.