Skip to content

latest manifest should point to v1.19.0-alpha.1, not v1.19.1-alpha.1#140

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
andrewsykim:manifest
Oct 1, 2020
Merged

latest manifest should point to v1.19.0-alpha.1, not v1.19.1-alpha.1#140
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
andrewsykim:manifest

Conversation

@andrewsykim
Copy link
Copy Markdown
Member

Signed-off-by: Andrew Sy Kim kim.andrewsy@gmail.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Latest tag is v1.19.0-alpha.1, not v1.19.1-alpha.1, our example manifests should reflect that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2020
@andrewsykim
Copy link
Copy Markdown
Member Author

/assign @nckturner

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@nckturner
Copy link
Copy Markdown
Contributor

/lgtm
Let me also rebuild and push the image with that tag. I used v1.19.1 for the k/k dependency version and apparently forgot that the patch version was reserved as the cloud provider version. My bad. I'll also add some docs around this. Looks like I got the tag right when I created the release though 😖

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [andrewsykim,nckturner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 35aeabd into kubernetes:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants