Skip to content

Merge legacy provider#160

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
nckturner:merge-legacy-provider
Feb 5, 2021
Merged

Merge legacy provider#160
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
nckturner:merge-legacy-provider

Conversation

@nckturner

@nckturner nckturner commented Dec 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This copies the v1 provider to the local v1 directory. This merge needs to be coordinated with an effort to stop accepting features into k/k (legacy-cloud-providers).

I was working off #151 (so those commits show up here too) as I am expecting us to get that in first, but I can separate this if for some reason we want this to merge first.

Does this PR introduce a user-facing change?:

The V1 AWS provider has been rehomed from `legacy-cloud-providers` to `cloud-provider-aws/pkg/providers/v1`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@nckturner

nckturner commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

/assign @andrewsykim

@nckturner

nckturner commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@andrewsykim

andrewsykim commented Dec 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

/hold

Just putting a hold on this until @nicolehanjing 's PR is merged

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2020
@nicolehanjing

nicolehanjing commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

/hold

Just putting a hold on this until @nicolehanjing 's PR is merged

@andrewsykim FYI my PR has merged

@nckturner

nckturner commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

Ok I will rebase this

@nckturner
nckturner force-pushed the merge-legacy-provider branch from f925c10 to 04c8b6c Compare January 29, 2021 18:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2021
@nckturner

nckturner commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@nckturner
nckturner force-pushed the merge-legacy-provider branch from 04c8b6c to fd6e918 Compare January 29, 2021 18:47
@ayberk

ayberk commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

@ayberk: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nckturner

nckturner commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

/cc @andrewsykim

@ayberk ayberk mentioned this pull request Feb 2, 2021
Closed
6 tasks
Copy legacy provider here
093f4f1 
- Stop importing the v1 provider because we need to move it out of
  upstream.
- Copy the v1 provider here, when this merges we need to stop
  accepting most or all features in the k/k (legacy-cloud-providers)
@nckturner
nckturner force-pushed the merge-legacy-provider branch from fd6e918 to 093f4f1 Compare February 5, 2021 08:30
@nckturner

nckturner commented Feb 5, 2021

Copy link
Copy Markdown
Contributor Author

/cc @wongma7

@k8s-ci-robot
k8s-ci-robot requested a review from wongma7 February 5, 2021 17:14
@wongma7

wongma7 commented Feb 5, 2021

Copy link
Copy Markdown

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot

k8s-ci-robot commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 6c10f4b into kubernetes:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb
@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh
@andrewsykim andrewsykim Awaiting requested review from andrewsykim
@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@andrewsykim andrewsykim

@wongma7 wongma7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nckturner @andrewsykim @nicolehanjing @ayberk @k8s-ci-robot @wongma7