Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs publishing script and improve documentation #161

Merged
merged 1 commit into from Dec 4, 2020

Conversation

nckturner
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind documentation

What this PR does / why we need it:
This PR includes a script (./hack/publish-docs.sh) that can be called from the command line or ideally in a github action to publish the docs to the github pages branch. This allows the docs to be hosted on github (see an example published from my fork).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@nckturner
Copy link
Contributor Author

/assign @andrewsykim

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2020
@nckturner nckturner force-pushed the docs-v1 branch 7 times, most recently from 4a03b82 to bd934a2 Compare December 4, 2020 09:33
@nckturner nckturner changed the title Add docs publishing script Add docs publishing script and improve documentation Dec 4, 2020
@nckturner nckturner force-pushed the docs-v1 branch 2 times, most recently from 66deb6d to 589bafe Compare December 4, 2020 18:42
- Docs script for publishing to github pages
- Split existing readme into docs sections
- Logos :D
@M00nF1sh
Copy link
Contributor

M00nF1sh commented Dec 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bf1debf into kubernetes:master Dec 4, 2020
@andrewsykim
Copy link
Member

thanks @nckturner, FYI @nicolehanjing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants