Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloudbuild and simplify Makefile & cloudbuild #162

Merged
merged 1 commit into from Dec 9, 2020

Conversation

nckturner
Copy link
Contributor

  • Remove cloudbuild logic from Makefile
  • Fix ldflags version
  • Use gcr.io/cloud-builders/docker for cloudbuild
    (tangentially, this should also fix the cloudbuild
    build, which was failing because of what appeared
    to be an env var collision between the Makefile
    and the build container with $IMAGE).

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind cleanup

What this PR does / why we need it:
Simplifies cloudbuild and Makefile (should fix it in the process, but we will need to merge it to see).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@nckturner nckturner force-pushed the fix-and-simplify-build branch 2 times, most recently from 27a4233 to c5ad5ae Compare December 8, 2020 11:26
@nckturner
Copy link
Contributor Author

/assign @andrewsykim

@nckturner
Copy link
Contributor Author

/cc @wongma7 @ayberk

@k8s-ci-robot
Copy link
Contributor

@nckturner: GitHub didn't allow me to request PR reviews from the following users: ayberk.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wongma7 @ayberk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Makefile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
- Remove cloudbuild logic from Makefile
- Fix ldflags version
- Use gcr.io/cloud-builders/docker for cloudbuild
  (tangentially, this should also fix the cloudbuild
  build, which was failing because of what appeared
  to be an env var collision between the Makefile
  and the build container with $IMAGE).
@wongma7
Copy link
Contributor

wongma7 commented Dec 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e293e75 into kubernetes:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants