Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloudbuild image name #163

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Dec 9, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fixes cloudbuild

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
cloudbuild.yaml Outdated
- 'gcr.io/$PROJECT_ID/cloud-controller-manager:$_GIT_TAG'
- 'gcr.io/$PROJECT_ID/cloud-controller-manager:latest'
- 'gcr.io/$PROJECT_ID/k8s-staging-provider-aws:$_GIT_TAG'
- 'gcr.io/$PROJECT_ID/k8s-staging-provider-aws:latest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both need to change i think to

'gcr.io/k8s-staging-provider-aws/cloud-controller-manager:latest'

I am not sure what PROJECT_ID is, see https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/cloudbuild.yaml for reference

@wongma7
Copy link
Contributor

wongma7 commented Dec 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 39a173c into kubernetes:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants