Repository navigation
Add released versions to README - #175
Conversation
|
@nckturner: GitHub didn't allow me to request PR reviews from the following users: ayberk. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| | Kubernetes Version | Latest AWS Cloud Provider Release Version | | ||
| |-----------------------------|-----------------------------------------------| | ||
| | v1.19 | v1.19.0-alpha.1 | |
There was a problem hiding this comment.
Is this table an example or do we intend to keep it up to date? given the description above, should be sufficient to just say
| kubernetes | cloud provider
| v1.19.x | v1.19.y |
are compatible
There was a problem hiding this comment.
also do we want to say that v1.19 is ONLY compatible with kubernetes 1.19 ? i.e. is that our only guarantee? IMO having a weak guarantee like that is fine, mixing and matching other versions are YMMV
There was a problem hiding this comment.
I was planning on keeping it up to date, since it might be an easy place to come look at if users are wondering what the latest is/if they are up to date.
There was a problem hiding this comment.
Yeah updating that version can get tedious if we plan to release often. Maybe we should just put vMajor.Minor similar to what @wongma7 suggested.
| The AWS Cloud Controller Manager is the controller that is primarily responsible for creating and updating AWS loadbalancers (classic and NLB) and node lifecycle management. The controller loops that are migrating out of the kube controller manager include the route controller, the service controller, the node controller, and the node lifecycle controller. | ||
|
|
||
| ### AWS Credential Provider | ||
| The AWS credential provider is a binary that is executed by kubelet to provide credentials for images in ECR. |
| ## Components | ||
|
|
||
| ### AWS Cloud Controller Manager | ||
| The AWS Cloud Controller Manager is the controller that is primarily responsible for creating and updating AWS loadbalancers (classic and NLB) and node lifecycle management. The controller loops that are migrating out of the kube controller manager include the route controller, the service controller, the node controller, and the node lifecycle controller. |
There was a problem hiding this comment.
link to kep or blog? (for more details)
89bc208 to
ce416b8
Compare
ce416b8 to
10c1925
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updated 1st page documentation to include released versions and context around the different code users might be interested in when navigating to this repository.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @wongma7 @ayberk @andrewsykim
Does this PR introduce a user-facing change?: