-
Notifications
You must be signed in to change notification settings - Fork 358
Replace book homepage with README #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Did the assets need to be included in the PR? |
|
To answer my previous question, looks like not. Another question -- should we 1. remove netlify, or 2. update it? cc @andrewsykim. I'm not sure I understand what benefit it provides. |
|
Well, it's hosted on Netlify and our subproject DNS points to that deployment(https://cloud-provider-aws.sigs.k8s.io/). I think I should be able to modify it to work. Let me try. |
|
/hold |
|
Oh got it. Yeah we should try to update it. |
4448dbc to
40f39f3
Compare
|
/unhold @nckturner Should be working now. |
|
Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Moved README to
/docsand set the/docsfolder as thedocs_dirso now README.md serves as the home page for the mkdocs.Tested on my fork.