Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace book homepage with README #176

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Feb 8, 2021

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Moved README to /docs and set the /docs folder as the docs_dir so now README.md serves as the home page for the mkdocs.

Tested on my fork.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2021
@nckturner
Copy link
Contributor

Did the assets need to be included in the PR?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@nckturner
Copy link
Contributor

To answer my previous question, looks like not. Another question -- should we 1. remove netlify, or 2. update it? cc @andrewsykim. I'm not sure I understand what benefit it provides.

@ayberk
Copy link
Contributor Author

ayberk commented Feb 8, 2021

Well, it's hosted on Netlify and our subproject DNS points to that deployment(https://cloud-provider-aws.sigs.k8s.io/). I think I should be able to modify it to work. Let me try.

@ayberk
Copy link
Contributor Author

ayberk commented Feb 8, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@nckturner
Copy link
Contributor

Oh got it. Yeah we should try to update it.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2021
@ayberk ayberk force-pushed the move_readme branch 7 times, most recently from 4448dbc to 40f39f3 Compare February 8, 2021 22:27
@ayberk
Copy link
Contributor Author

ayberk commented Feb 8, 2021

/unhold

@nckturner Should be working now. deploy/netlify correctly renders the docs. I think it deploys to the actual site when we merge to master.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@nckturner
Copy link
Contributor

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 372ff75 into kubernetes:master Feb 9, 2021
@ayberk ayberk deleted the move_readme branch April 29, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants