Add a docs page for the service controller#197
Add a docs page for the service controller#197k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
cncf-cla: yes
ayberk
left a comment
ayberk
left a comment
There was a problem hiding this comment.
Nothing to block this PR. Minor suggestions that can be done later.
| # The Service Controller | ||
|
|
||
| The service controller is responsible for watch for service and node object changes, so that it can create, update, or delete cloud load balancers corresponding to load balanced services. Like the other controllers, we import the cloud-provider provided utility functions for managing the controller itself, which calls into cloud provider defined methods `GetLoadBalancer`, `GetLoadBalancerName`, `EnsureLoadBalancer`, `UpdateLoadBalancer`, and `EnsureLoadBalancerDeleted`. | ||
|
|
There was a problem hiding this comment.
Annotation values have no constraints, right? I looked at the docs and looks like there are rules only for the keys. Just making sure so we don't give the users the wrong impression with Valid Values : -
There was a problem hiding this comment.
Yeah it might not be quite the correct way to phrase it..
| repo_url: https://github.com/kubernetes/cloud-provider-aws/ | ||
| nav: | ||
| - 'Home': README.md | ||
| - 'Components': |
There was a problem hiding this comment.
This is minor, but I think these tabs are listed by the order they have here. We might want to move it to between user guide and development.
There was a problem hiding this comment.
That makes sense. We can do in a follow up.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add documentation for load balancer annotations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: