-
Notifications
You must be signed in to change notification settings - Fork 363
A missing item #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A missing item #204
Conversation
I hope this will save other people's time...
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @oguzhanun! |
|
Hi @oguzhanun. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @oguzhanun. Before we can merge your contribution, we'll need you to sign the CLA. It looks like your commit is correctly associated with your github account, so you just need to sign the CLA using an email you use for you Github account. You can see all email addresses associated with your Github account in your account settings. https://git.k8s.io/community/CLA.md#the-contributor-license-agreement |
|
/ok-to-test |
|
Hi @ayberk, thanks a lot for your help. I have completed the signing procedures. |
|
This is helpful, but probably not enough information. In fact, I think we should merge this and then add more context. I'll create an issue after this merges. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, oguzhanun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I hope this will save other people's time...
What type of PR is this?
What this PR does / why we need it:
It improves the quality of the documentation.
Which issue(s) this PR fixes:
Fixes #
A to-do list to be able to run AWS cloud-controller-manager on a k8s cluster.
Special notes for your reviewer:
Thanks for your time...
Does this PR introduce a user-facing change?:
NONE