Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to v1.21.0 #205

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Apr 20, 2021

Bump dependencies to v1.21.0

  • Move to NewCloudControllerManagerCommand to remove copy/paste template
    code, we don't do anything too special here that requires
    duplication of the command creation.
NONE

@nckturner nckturner requested a review from wongma7 April 20, 2021 23:07
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 20, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 20, 2021
@nckturner
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2021
@nckturner nckturner changed the title 1.21 release commit v1.21.0 alpha release Apr 20, 2021
@nckturner nckturner changed the title v1.21.0 alpha release Move dependencies to v1.21.0 Apr 20, 2021
@nckturner nckturner changed the title Move dependencies to v1.21.0 Bump dependencies to v1.21.0 Apr 20, 2021
* Move to NewCloudControllerManagerCommand to remove copy/paste template
  code, we don't do anything too special here that requires
  duplication of the command creation.
@wongma7
Copy link
Contributor

wongma7 commented Apr 20, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@nckturner
Copy link
Contributor Author

Tested successfully in kops, of note, --configure-cloud-routes must now be set to false and an additional permission needs to be set on the cluster role (create serviceaccounts/token in kube-system), but I don't understand why this is required for cloud-controller-manager, because ideally only kube-controller-manager should need to create service account tokens?

@nckturner
Copy link
Contributor Author

This is probably mergable to allow for testing 1.21 alpha images, we do need to address the permission in kops when we add the 1.21 image there (there is a hardcoded list of the alpha image versions right now).

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants