Skip to content

Bump dependencies to v1.21.0#205

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nckturner:release-1.21
Apr 22, 2021
Merged

Bump dependencies to v1.21.0#205
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nckturner:release-1.21

Conversation

@nckturner
Copy link
Contributor

@nckturner nckturner commented Apr 20, 2021 •
edited
Loading

Bump dependencies to v1.21.0

  • Move to NewCloudControllerManagerCommand to remove copy/paste template
    code, we don't do anything too special here that requires
    duplication of the command creation.
NONE

@nckturner nckturner requested a review from wongma7 April 20, 2021 23:07
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 20, 2021
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh April 20, 2021 23:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 20, 2021
@nckturner
Copy link
Contributor Author

nckturner commented Apr 20, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2021
@nckturner nckturner changed the title 1.21 release commit v1.21.0 alpha release Apr 20, 2021
@nckturner nckturner changed the title v1.21.0 alpha release Move dependencies to v1.21.0 Apr 20, 2021
@nckturner nckturner changed the title Move dependencies to v1.21.0 Bump dependencies to v1.21.0 Apr 20, 2021
@nckturner
Bump dependencies to v1.21.0
76bbfdd 
* Move to NewCloudControllerManagerCommand to remove copy/paste template
  code, we don't do anything too special here that requires
  duplication of the command creation.
@wongma7
Copy link

wongma7 commented Apr 20, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@nckturner
Copy link
Contributor Author

nckturner commented Apr 22, 2021

Tested successfully in kops, of note, --configure-cloud-routes must now be set to false and an additional permission needs to be set on the cluster role (create serviceaccounts/token in kube-system), but I don't understand why this is required for cloud-controller-manager, because ideally only kube-controller-manager should need to create service account tokens?

@nckturner
Copy link
Contributor Author

nckturner commented Apr 22, 2021

This is probably mergable to allow for testing 1.21 alpha images, we do need to address the permission in kops when we add the 1.21 image there (there is a hardcoded list of the alpha image versions right now).

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7a3c96b into kubernetes:master Apr 22, 2021
This was referenced May 11, 2022
Closed
Merged
Closed
nckturner added a commit that referenced this pull request May 12, 2022
@saurav-agarwalla @nckturner @nguyenkndinh
Automated cherry pick of #205: Bump dependencies to v1.21.0#308: Add …
c67824f 
…tagging controller configuration#334: Stop retrying failed workitem after a certain amount of (#361)

* Add tagging controller

Co-authored-by: Nick Turner <nic@amazon.com>
Co-authored-by: Nguyen Dinh <92940366+nguyenkndinh@users.noreply.github.com>
@hakman hakman mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wongma7 wongma7 Awaiting requested review from wongma7

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@wongma7 wongma7

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nckturner @wongma7 @k8s-ci-robot